refactor: move collection reactions into store integration#556
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the collection management logic to use an event-driven architecture, replacing direct port calls with workspace event emissions. It introduces a new integration to handle events such as entry creation, deletion, renaming, and moving, while updating the collection slice to correctly process file-level changes. Feedback highlights a potential race condition due to unawaited event emissions in the tree actions and suggests aligning the onEntryCreated method signature with other event handlers for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review
Testing
Notes