Skip to content

feat: add fixed tab number shortcuts#563

Merged
hhhjin merged 2 commits into
mainfrom
codex/fixed-tab-hotkeys
Apr 12, 2026
Merged

feat: add fixed tab number shortcuts#563
hhhjin merged 2 commits into
mainfrom
codex/fixed-tab-hotkeys

Conversation

@hhhjin
Copy link
Copy Markdown
Member

@hhhjin hhhjin commented Apr 12, 2026

Summary

  • add fixed Mod+1 through Mod+9 tab switching shortcuts in the desktop hotkey layer
  • reserve those bindings in the store hotkey utilities and reject them in hotkey settings
  • add coverage for tab-number resolution and reserved-binding validation

Testing

  • pnpm test:packages
  • pnpm ts:check:desktop
  • pnpm lint:fix

Notes

  • existing saved custom Mod+1 through Mod+9 bindings are not migrated in this patch

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces fixed tab switching shortcuts (Mod+1 through Mod+9) and prevents these reserved bindings from being overridden in the application settings. The changes include a new utility for tab lookup, UI integration for the shortcuts, and validation logic in the store. Feedback suggests hardening the reservation check to include 'Ctrl' prefixes for cross-platform consistency, optimizing the tab activation callback to avoid unnecessary re-renders, and importing the reservation utility in the UI component.

Comment thread packages/store/src/hotkeys/hotkey-utils.ts
Comment thread apps/desktop/src/components/hotkeys/hotkeys.tsx
Comment thread apps/desktop/src/components/hotkeys/hotkeys.tsx
@hhhjin hhhjin merged commit 5af172c into main Apr 12, 2026
3 checks passed
@hhhjin hhhjin deleted the codex/fixed-tab-hotkeys branch April 12, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant