Skip to content

Ignore disabled mod folder#62

Merged
fifty-six merged 1 commit into
hk-modding:masterfrom
SFGrenade:master
Jul 24, 2021
Merged

Ignore disabled mod folder#62
fifty-six merged 1 commit into
hk-modding:masterfrom
SFGrenade:master

Conversation

@SFGrenade
Copy link
Copy Markdown
Member

No description provided.

@fifty-six
Copy link
Copy Markdown
Member

I don't think this is necessary because the disabled folder would contain folders and the loader only looks one deep.

@SFGrenade
Copy link
Copy Markdown
Member Author

yes, but it would fuck with people updating from 1.4.3.2, when they still have dll files in the disabled folder thanks to old(current) modinstallers

@fifty-six fifty-six closed this Jul 23, 2021
@fifty-six
Copy link
Copy Markdown
Member

In theory I'd want to clear those out when migrating but special casing it might be reasonable. I'd just .Except(Directory.GetFiles(Path.Combine(managed, "Disabled))) instead of branching on every dir though.

@fifty-six fifty-six reopened this Jul 24, 2021
@SFGrenade
Copy link
Copy Markdown
Member Author

brb rewriting history

@fifty-six fifty-six merged commit b6844cb into hk-modding:master Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants