Added support for Tuples#374
Merged
LPTK merged 20 commits intohkust-taco:hkmc2from Jan 23, 2026
Merged
Conversation
LPTK
reviewed
Jan 1, 2026
Contributor
LPTK
left a comment
LPTK
left a comment
There was a problem hiding this comment.
Neat! This looks well done to me. WDYT @Derppening?
Derppening
reviewed
Jan 2, 2026
Contributor
Derppening
left a comment
Derppening
left a comment
There was a problem hiding this comment.
Apart from some fields that appear to be better located in Ctx than WatBuilder, the rest looks good to me.
Please do add documentation where possible, including private members.
Derppening
reviewed
Jan 15, 2026
Contributor
Derppening
left a comment
Derppening
left a comment
There was a problem hiding this comment.
Please address the comments and also add some brief documentation for the private functions.
Derppening
reviewed
Jan 19, 2026
Contributor
Derppening
left a comment
Derppening
left a comment
There was a problem hiding this comment.
LGTM.
Please add some brief documentation for the newly-added private functions as mentioned in the previous review.
Derppening
reviewed
Jan 21, 2026
Contributor
Derppening
left a comment
Derppening
left a comment
There was a problem hiding this comment.
This looks almost good to be merged. Please address the remaining comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.