3.5.0 #161
Open
3.5.0 #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 946f562.
* added DkCoreDocumentReference * Update aliases.fsh * Alternative DocRef approach (#158) * Alternative DocRef approach * Further danish constraints * Removed unused alias * update scripts * Update DkCoreDocumentReference.fsh --------- Co-authored-by: Ole Vilstrup <ovi@medcom.dk>
150 profiling of encounter
Added context.sourcePatientInfo only Reference(DkCorePatient)
outcommented context.sourcePatientInfo only Reference(DkCorePatient)
Created short intro page for DocumentReference
Closed
Explicit display values for IEEEx73 codes no longer needed
This was referenced Oct 6, 2025
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jacand
reviewed
Nov 27, 2025
input/fsh/DkCorePractitioner.fsh
Outdated
| * ^slicing.discriminator.path = "identifier.system" | ||
| * ^slicing.rules = #open | ||
| * ^slicing.ordered = false | ||
| * ^slicing.description = "Slice based on the identifier.systemm value which allows for official qualifications to\nDeclaring the slices, and their cardinalities, to allow a KL-code and a SNOMED CT code" |
Collaborator
There was a problem hiding this comment.
@jkiddo Note that Copilot actually found and fixed a spelling mistake in the change suggestion above that you missed: systemm -> system
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
Clarify the role of the implementation guide in relation to the FHIR standard and the IPA specification.
…iblity and link to example of diagnosis and ranks.
[(181-review-encounter-example-missing)] More descriptions of respons…
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
| Extension: DkCoreDocumentReferenceVersionID | ||
| Id: dk-core-documentreference-version-id-extension | ||
| Title: "HL7 Denmark core DocumentReference Version ID extension" | ||
| Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource." |
There was a problem hiding this comment.
The extension is missing context definition. Extensions should define where they can be used via ^context.type and ^context.expression. For a DocumentReference version extension, add:
* ^context.type = http://hl7.org/fhir/extension-context-type#element
* ^context.expression = "DocumentReference"
Suggested change
| Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource." | |
| Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource." | |
| * ^context.type = http://hl7.org/fhir/extension-context-type#element | |
| * ^context.expression = "DocumentReference" |
| * extension[0].url = "http://hl7.dk/fhir/core/StructureDefinition/dk-core-planned-start-date" | ||
| * extension[=].valueDateTime = "2025-11-14T09:00:00.0000+01:00" | ||
| * extension[+].url = "http://hl7.dk/fhir/core/StructureDefinition/dk-core-planned-end-date" | ||
| * extension[=].valueDateTime = "2025-11-15" |
There was a problem hiding this comment.
[nitpick] The planned end date uses a date-only value "2025-11-15" while the planned start date uses a full dateTime "2025-11-14T09:00:00.0000+01:00". For consistency and clarity, consider using the same precision (dateTime format) for both planned dates, especially since the extension is defined as valueDateTime.
Suggested change
| * extension[=].valueDateTime = "2025-11-15" | |
| * extension[=].valueDateTime = "2025-11-15T09:00:00.0000+01:00" |
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Fix typo: reponsibilities -> responsibilities Co-authored-by: jkiddo <211696+jkiddo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkiddo <211696+jkiddo@users.noreply.github.com>
RikkeVestesen
approved these changes
Dec 15, 2025
Collaborator
RikkeVestesen
left a comment
RikkeVestesen
left a comment
There was a problem hiding this comment.
Jeg har et enkelt spørgsmål til en dependency
Fixing #130
Comment out the hl7.fhir.extensions.r5 dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.