Fix release automation#3547
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3547 +/- ##
==========================================
- Coverage 81.05% 74.29% -6.76%
==========================================
Files 246 252 +6
Lines 31677 37470 +5793
Branches 0 5078 +5078
==========================================
+ Hits 25675 27840 +2165
- Misses 6002 9630 +3628 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hluk
force-pushed
the
fix-release-automation
branch
3 times, most recently
from
a088b69 to
00abcae
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the release/CI automation by making release drafting fail fast on broken builds, fixing GitHub Actions references, and adding local validation tooling for workflow files.
Changes:
- Update
draft-release.shto watch CI build runs (and fail on build failure) instead of polling the release for artifacts. - Harden GitHub Actions workflows (permissions, checkout creds, cache restore/save split, workspace path fixes, corrected action pin).
- Add pre-commit hooks (
actionlint,zizmor) and align build/install directories (_install) with presets and.gitignore.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/github/draft-release.sh | Switches from artifact polling to watching CI runs before proceeding with release drafting. |
| CMakePresets.json | Moves build/install dirs under ${sourceDir} and introduces _install for install outputs. |
| .pre-commit-config.yaml | Adds actionlint and zizmor hooks to validate workflows in pre-commit. |
| .gitignore | Ignores _install directory created by updated CMake presets/workflows. |
| .github/workflows/codespell.yml | Uses checkout with persist-credentials: false. |
| .github/workflows/build-windows.yml | Adds least-privilege permissions, fixes cache usage, aligns paths with presets, and updates artifact download pin. |
| .github/workflows/build-macos.yml | Adds least-privilege permissions, fixes cache usage, aligns paths with presets, and updates artifact download pin. |
| .github/workflows/build-linux.yml | Adds least-privilege permissions, aligns build/install paths with presets (_install). |
| .github/dependabot.yml | Adds update cooldown and groups GitHub Actions updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hluk
force-pushed
the
fix-release-automation
branch
from
00abcae to
0207a0c
Compare
Fixes waiting on builds - it should fail right away if some builds fail. Fixes invalid GitHub Action reference. Adds actionlint and zizmor pre-commit hooks to ensure the GitHub Actions are valid and secure. Assisted-by: Claude (Anthropic)
hluk
force-pushed
the
fix-release-automation
branch
from
0207a0c to
53a82b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes waiting on builds - it should fail right away if some builds fail.
Fixes invalid GitHub Action reference.
Adds actionlint pre-commit hook to ensure the GitHub Actions are valid.
Assisted-by: Claude (Anthropic)