Skip to content

feat(main_editor): enableSubEditorPage#752

Merged
hm21 merged 1 commit intohm21:stablefrom
saif-ellafi:enableSubPage
Feb 3, 2026
Merged

feat(main_editor): enableSubEditorPage#752
hm21 merged 1 commit intohm21:stablefrom
saif-ellafi:enableSubPage

Conversation

@saif-ellafi
Copy link
Contributor

PR Checklist (Required)

Please ensure your PR meets the following requirements:

  • The commit message follows our guidelines: https://github.com/hm21/pro_image_editor/blob/stable/CONTRIBUTING.md#style-guides
  • I have run dart format . in the terminal and committed any changes.
  • I have run dart analyze . in the terminal and addressed any issues.
  • I have run flutter test in the terminal and addressed any issues.
  • I have pulled from the stable branch before committing.
  • I have updated the CHANGELOG.md file with my changes (For the version, you can use X.X.X, I will later bump it after it's merged).
  • The PR title follows the conventional commit style (e.g., feat(paint-editor): add new triangle shape).
  • If this PR introduces breaking changes, I have verified that there is no way to implement the changes without them.

PR Checklist (Optional)

  • Tests have been added for the changes.
  • Documentation has been added/updated.

PR Type

Please indicate the types of changes this PR introduces by checking the relevant boxes:

  • Bugfix
  • Feature
  • Performance
  • Refactor (no functional or API changes)
  • Code style updates (e.g., formatting, local variables)
  • Documentation updates
  • CI-related changes
  • Other... Please describe:

Current Behavior

Crop and paintEditor open in full screen, regardless of the constraints of the main editor. This PR allows using subPage within the constraints.

Why? I am not sure what happened, but recently a bug was introduced, and adding painting layers, which are added in full screen, fully shifts the painting layers upon closing the subPage. I have honestly no idea when this regression was introduced.

Issue Number: N/A

New Behavior

Although the shift bug has not been fixed, allowing subPage editors within constraints solves the problem and allows for a nicer UX.

Breaking Changes?

Does this PR introduce a breaking change?

  • Yes
  • No

Additional Information

@saif-ellafi
Copy link
Contributor Author

saif-ellafi commented Feb 3, 2026

my app from December 24th 2025 did not have this full-screen paintEditor issue, so this was indeed some regression. Perhaps this PR is not needed if the actual bug is found.

EDIT: Looks like the regression was on my end, as I removed a Navigator() wrapper
EDIT 2: Indeed, regression was on my end. However this PR might still be better than having developer side wrap a Navigator to bypass full screen. I like this PR as is, it is clearer this way.

Copy link
Owner

@hm21 hm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for creating that PR!

@hm21 hm21 merged commit 2206cf5 into hm21:stable Feb 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants