feat(main_editor): enableSubEditorPage#752
Merged
hm21 merged 1 commit intohm21:stablefrom Feb 3, 2026
Merged
Conversation
Contributor
Author
|
my app from December 24th 2025 did not have this full-screen paintEditor issue, so this was indeed some regression. Perhaps this PR is not needed if the actual bug is found. EDIT: Looks like the regression was on my end, as I removed a |
hm21
approved these changes
Feb 3, 2026
Owner
hm21
left a comment
There was a problem hiding this comment.
LGTM thanks for creating that PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (Required)
Please ensure your PR meets the following requirements:
dart format .in the terminal and committed any changes.dart analyze .in the terminal and addressed any issues.flutter testin the terminal and addressed any issues.CHANGELOG.mdfile with my changes (For the version, you can use X.X.X, I will later bump it after it's merged).feat(paint-editor): add new triangle shape).PR Checklist (Optional)
PR Type
Please indicate the types of changes this PR introduces by checking the relevant boxes:
Current Behavior
Crop and paintEditor open in full screen, regardless of the constraints of the main editor. This PR allows using subPage within the constraints.
Why? I am not sure what happened, but recently a bug was introduced, and adding painting layers, which are added in full screen, fully shifts the painting layers upon closing the subPage. I have honestly no idea when this regression was introduced.
Issue Number: N/A
New Behavior
Although the shift bug has not been fixed, allowing subPage editors within constraints solves the problem and allows for a nicer UX.
Breaking Changes?
Does this PR introduce a breaking change?
Additional Information