fix(extract_audio): refactored to use sync file write to improve stability#125
Merged
hm21 merged 1 commit intohm21:stablefrom Apr 19, 2026
Merged
Conversation
hm21
approved these changes
Apr 19, 2026
Owner
hm21
left a comment
hm21
left a comment
There was a problem hiding this comment.
LGTM thanks for creating that PR which fix this issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue: Closes #116
Apparently my previous attempt wasn't successful and there are still some issues on iOS.
This PR change audio export to use sync file write, to avoid issues the write session start.
Tested it with the example app and my internal audio dataset.
Type of Change