DFI-1266 API scopes for disa-returns #119
Conversation
|
| "key":"read:isa-returns", | ||
| "name":"Access ISA returns reports", | ||
| "description":"Scope to access ISA returns reports" | ||
| }, |
There was a problem hiding this comment.
Is 'returns reports' a tautology like 'PIN number'?
I would go with:
- Access ISA returns
- Scope to access ISA returns
Given that new API name is going to be ISA Returns, we might need to default to using 'returns' in API schema and use 'report' or 'reports' only in descriptive text when talking specifically about monthly reports/reporting. At DISA Phase 2, if annual ISA statistical returns are added to API, they will always be referred to as 'returns'.
There was a problem hiding this comment.
I'm not too sure on that one tbh, I thought the report was the result of submitting ISA returns and the only data the user can access currently in API is the reconciliation reports but maybe thats my misunderstanding and probably limiting for future iterations on the API.
Happy to change to the suggestions 👍🏼
| "key":"write:isa-returns", | ||
| "name":"Submit ISA returns and ISA manager’s declaration", | ||
| "description":"Scope to submit ISA returns and the ISA manager’s declaration" | ||
| } |
fmcgrath
left a comment
fmcgrath
left a comment
There was a problem hiding this comment.
2 minor comments but 1 of them is a discussion point.
5 participants
No description provided.