GG-8781 domain : add missing generators to test jar #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving the shared lib into the domain-play-30 as we now only support the play3. Adding the domain-test-play-30 to contain the generators so other projects can import it.
szabolcs-szilagyi-hmrc
changed the title
|
updates the README with the new examples, syntax
|
tim-holbrook
reviewed
Aug 5, 2025
| * @example | ||
| * NinoGenerator(seed).nextNino.nino | ||
| */ | ||
| case class NinoGenerator(private val random: Random = new Random) extends Modulus23Check { |
There was a problem hiding this comment.
Just confirming that Nino generator follows these rules:
Contributor
Author
There was a problem hiding this comment.
Yes, it is generating valid ninos that conforms the rules on the wikipedia page. Here is most of the code that does that: https://github.com/hmrc/domain/blob/GG-8781/domain-play-30/src/main/scala/uk/gov/hmrc/domain/Nino.scala#L49
tim-holbrook
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restructuring the library's modules
moving the shared lib into the domain-play-30 as we now only support the play3. Adding the domain-test-play-30 to contain the generators so other projects can import it.