DTR-3013: update Create-and-update Subcontractor request#48
Merged
codeneto-hmrc merged 3 commits intomainfrom Feb 24, 2026
Merged
DTR-3013: update Create-and-update Subcontractor request#48codeneto-hmrc merged 3 commits intomainfrom
codeneto-hmrc merged 3 commits intomainfrom
Conversation
jassalrichy
reviewed
Feb 20, 2026
| addressLine2 = None, | ||
| city = Some("London"), | ||
| county = Some("Greater London"), | ||
| country = Some("GB"), |
Contributor
There was a problem hiding this comment.
country expect the country name rather than the country code:
please change all test country values from "GB" to "United Kingdom"
Contributor
Author
There was a problem hiding this comment.
The country field is defined as a String, so this test is validating the string value itself rather than enforcing a specific format or country code. Since we are asserting against the exact value any string would technically be suffice i believe.
That said, I see your point using a realistic value would improve readability.
jassalrichy
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.