BDOG-2885 Build for Play 3.0 #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorarbuesmallada
previously approved these changes
Nov 10, 2023
colin-lamed
force-pushed
the
BDOG-2885
branch
from
907e67f to
15c5af4
Compare
colin-lamed
force-pushed
the
BDOG-2885
branch
from
15c5af4 to
0df2230
Compare
Shnick
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than providing (private) type aliases for Play 2.8, Play 2.9, Play 3.0 for akka/pekko, I have opted to provide sources for Play 3.0, and replace the namespaces for Play 2.8, 2.9. This may be a little more complicated for the library, but will be a lot simpler for library clients who won't have a (private) level of redirection to navigate. And simpler when we can drop support for Play 2.8/2.9 to clean up.