cleanup writeString()#55
Merged
hmueller01 merged 1 commit intomasterfrom Jul 13, 2025
Merged
Conversation
… writeString(const char* string, uint8_t* buf, size_t pos, size_t size)
Collaborator
|
|
Owner
Author
|
ATM always this->buffer is used, so this->buffer_size is always the max length. So yes, the member could be stripped by the two variables ... |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed writeString(const char* string, uint8_t* buf, size_t pos) by using writeString(const char* string, uint8_t* buf, size_t pos, size_t size) all over.
This reduces stack consumption and avoids potential errors if called with another buffer that
this->buffer.