fix: update zoom RTMS start endpoint to use a PATCH request#19
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the Zoom RTMS SDK control client to use HTTP PATCH instead of POST when updating RTMS status. The implementation change is a single-line method substitution in the client, test mocks are updated to verify PATCH behavior, and new API documentation explains the endpoint, required payload, and authorization scope. ChangesZoom RTMS Control HTTP Method Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…to feat/zoom-sdk-integration
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/sdk/test_zoom_rtms_control.py (1)
72-72: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winUpdate test function name to reflect PATCH method.
The test function name
test_zoom_rtms_start_posts_expected_payloadstill references "posts" but now tests PATCH behavior. Renaming totest_zoom_rtms_start_patches_expected_payloadwould improve clarity.📝 Suggested rename
-def test_zoom_rtms_start_posts_expected_payload(monkeypatch, db_session): +def test_zoom_rtms_start_patches_expected_payload(monkeypatch, db_session):🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/sdk/test_zoom_rtms_control.py` at line 72, Rename the test function currently named test_zoom_rtms_start_posts_expected_payload to reflect that it verifies PATCH behavior by renaming it to test_zoom_rtms_start_patches_expected_payload; update the function definition (def test_zoom_rtms_start_posts_expected_payload(...)) to def test_zoom_rtms_start_patches_expected_payload(...) so the name matches the tested HTTP method and intent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/sdk/test_zoom_rtms_control.py`:
- Line 72: Rename the test function currently named
test_zoom_rtms_start_posts_expected_payload to reflect that it verifies PATCH
behavior by renaming it to test_zoom_rtms_start_patches_expected_payload; update
the function definition (def test_zoom_rtms_start_posts_expected_payload(...))
to def test_zoom_rtms_start_patches_expected_payload(...) so the name matches
the tested HTTP method and intent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 85893a64-fa14-4ec0-85a3-6d3ec2dc7265
📒 Files selected for processing (3)
docs/sdk/zoom-rtms-sdk-prototype.mdsdk/providers/zoom_rtms/control.pytests/sdk/test_zoom_rtms_control.py
Description
Adds secure Zoom OAuth handling and fixes backend-controlled RTMS start requests. This patch validates OAuth state before token exchange, encrypts stored Zoom OAuth tokens, handles Zoom network errors consistently, and updates the RTMS control client to call Zoom’s required
PATCH /live_meetings/{meetingId}/rtms_app/statusendpoint.Type of Change
feat— New featurefix— Bug fixrefactor— Code refactoring (no functional change)docs— Documentation updatetest— Adding or updating testschore— Maintenance (dependencies, CI, tooling)Related Issue
Closes #
Changes Made
SDK_TOKEN_ENCRYPTION_KEY.PATCHinstead ofPOST.Proof of Work
API Response / Screenshots
Test Cases
Test output
make lint # All checks passed!Checklist
Summary by CodeRabbit
Documentation
Bug Fixes