Conversation
…igration fix: ci test needs to enable PG Vector Extension
fix/case normalization
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Benji918
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes backend email normalization inconsistencies by enforcing canonical email handling (
trim + lowercase) at both the schema and service layers in authentication flows.It prevents duplicate-account edge cases caused by casing or whitespace differences, ensures consistent login and existence checks, and keeps verification-related email inputs aligned with the same normalization behavior.
Type of Change
Related Issue
Closes #
Changes Made
Added/updated schema-level email normalization
Updated auth request schemas to consistently:
Applied to:
SignupRequestLoginRequestForgotPasswordRequestAdded service-layer normalization in
AuthServiceNormalization is now enforced even outside schema-bound request paths.
Updated:
check_email_existscreate_userloginThis ensures all auth flows use canonical email handling regardless of entry point.
Added and extended tests
Added coverage to verify:
Proof of Work
API Response / Screenshots
Scenario: Case/whitespace-insensitive signup + login
Request 2 —
POST /api/v1/auth/signupChecklist
<type>/<short-description>)uv run pytest)