feat(email): enhance email services with welcome and account deletion…#87
Merged
Conversation
… emails, update templates, and improve verification flow
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Benji918
previously approved these changes
May 30, 2026
Benji918
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrates three new transactional email templates (welcome, reset password, account deletion) into the email service. Templates follow the existing Jinja2 pattern in
app/templates/emails/and are wired into the appropriate service layer trigger points.Type of Change
feat— New featureRelated Issue
Closes #
Changes Made
app/templates/emails/welcome.html— sent after successful email verificationapp/templates/emails/reset_password.html— replaces the previous minimal templateapp/templates/emails/account_deletion.html— sent when account deletion is requestedapp/templates/emails/assets/— icons and background image referenced by templatessend_welcome_email()toapp/services/email_service.pysend_account_deletion_email()toapp/services/email_service.pysend_welcome_email()intoVerificationService.verify_email()after user is marked verifiedsend_password_reset_email()to use the new richer templateProof of Work
API Response / Screenshots
Test Cases
test_send_welcome_email_renders_without_errortest_send_reset_password_email_renders_without_errortest_send_account_deletion_email_renders_without_errorTest output
Checklist
feat/email-templates)uv run pytest)