Skip to content

Revert "feat(auth/talent): add linkedin_url + is_job_ready to /me; snake_case onboarding profile DTOs"#160

Merged
oduwoleeyinojuoluwa44 merged 1 commit into
devfrom
revert-159-feat/me-linkedin-job-ready-snake-case
May 28, 2026
Merged

Revert "feat(auth/talent): add linkedin_url + is_job_ready to /me; snake_case onboarding profile DTOs"#160
oduwoleeyinojuoluwa44 merged 1 commit into
devfrom
revert-159-feat/me-linkedin-job-ready-snake-case

Conversation

@oduwoleeyinojuoluwa44
Copy link
Copy Markdown
Collaborator

@oduwoleeyinojuoluwa44 oduwoleeyinojuoluwa44 commented May 28, 2026

Reverts #159

Summary by CodeRabbit

  • Bug Fixes

    • Removed password change endpoint
  • Refactor

    • Standardized API field names to camelCase across talent profile and user authentication endpoints
    • Updated authentication response structure: removed job-ready status field, added LinkedIn URL field
  • Tests

    • Removed profile verification-related test cases

Review Change Stack

Copilot AI review requested due to automatic review settings May 28, 2026 14:48
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 05589a75-8d0d-48a9-877b-1d1e3505add1

📥 Commits

Reviewing files that changed from the base of the PR and between d1773c7 and 3c82245.

📒 Files selected for processing (6)
  • src/modules/auth/auth.controller.ts
  • src/modules/auth/auth.service.get-profile.spec.ts
  • src/modules/auth/auth.service.ts
  • src/modules/talent/dto/save-talent-profile.dto.ts
  • src/modules/talent/dto/set-profile.dto.ts
  • src/modules/talent/talent.service.ts

📝 Walkthrough

Walkthrough

This PR removes the changePassword endpoint from AuthController, refactors talent profile DTOs from snake_case to camelCase property naming, updates the AuthUser interface to include linkedin_url and remove is_job_ready, and adjusts TalentService to map camelCase DTO fields to database columns.

Changes

Auth API and Talent Profile Refactoring

Layer / File(s) Summary
Auth API contract and AuthUser shape update
src/modules/auth/auth.controller.ts, src/modules/auth/auth.service.ts
AuthController removes the authenticated changePassword endpoint. AuthUser interface replaces the is_job_ready field with linkedin_url field. AuthService.getProfile query is narrowed to select track, linkedin_url, and profile_verified (removing status), and returns the new AuthUser shape.
Talent profile DTO camelCase property naming
src/modules/talent/dto/save-talent-profile.dto.ts, src/modules/talent/dto/set-profile.dto.ts
SaveTalentProfileDto and SetProfileDto properties transition from snake_case (education_level, linkedin_url, avatar_url) to camelCase (educationLevel, linkedinProfile/linkedinUrl, avatarUrl). Validation error messages are updated to reference the new camelCase names.
Talent service field mapping to camelCase DTO properties
src/modules/talent/talent.service.ts
saveTalentProfile and saveProfile methods are updated to read camelCase DTO properties and map them to snake_case database columns. The profile_verified calculation is updated to require educationLevel and linkedinProfile presence alongside region.

Possibly related PRs

  • hngprojects/skill-bridge-api#159: Added changePassword endpoint and altered AuthService.getProfile talent field mapping, while this PR removes changePassword and further refactors the talent profile shape.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-159-feat/me-linkedin-job-ready-snake-case

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oduwoleeyinojuoluwa44 oduwoleeyinojuoluwa44 merged commit 968bbb2 into dev May 28, 2026
5 of 7 checks passed
@oduwoleeyinojuoluwa44 oduwoleeyinojuoluwa44 review requested due to automatic review settings May 28, 2026 15:10
zxenonx pushed a commit that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant