Angular upgrade to v16#183
Merged
jggoebel merged 60 commits intohobbyfarm:masterfrom Mar 8, 2024
Merged
Conversation
Markdown pipe now returns SafeHTML but ngx-dynamic-hooks expects string
Category form can become null during runtime. Hence let's make it nullable during compile time, too.
If the observable does not emit any value and completes directly, using first() results in an error. Using take(1) generally does the same as first() but with a minor difference. take(1) mirrors the empty source observable in case it is empty and then also completes instead of throwing an error as first() does.
Otherwise the alerts cannot be closed via two-way-binding...
Advantages: ngAfterViewInit is only called once. So, we only need to manage one subscription.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the Angular version from v12 to v16.
fixes hobbyfarm/hobbyfarm#301