[codex] add check forbidden tags hook#129
Merged
hofbi merged 1 commit intoApr 30, 2026
Merged
Conversation
lukasoyen
force-pushed
the
codex/add-forbidden-tag-hook-followup
branch
2 times, most recently
from
e857947 to
1859fbf
Compare
hofbi
reviewed
Apr 30, 2026
lukasoyen
force-pushed
the
codex/add-forbidden-tag-hook-followup
branch
from
1859fbf to
069642e
Compare
lukasoyen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
check-forbidden-tagsBazel pre-commit hook.The hook reports Bazel rule calls containing a disallowed tag and supports
--allow-in-rule-kindto permit that tag for rule kinds matching a regular expression.Validation
uv run --extra dev pytest tests/test_build_file_parsing_util.py tests/test_check_rule_has_tag.py tests/test_check_forbidden_tags.pyuv run --with ruff ruff check dev_tools/build_file_parsing_util.py dev_tools/check_rule_has_tag.py dev_tools/check_forbidden_tags.py tests/test_build_file_parsing_util.py tests/test_check_rule_has_tag.py tests/test_check_forbidden_tags.pyuv run --with ruff ruff format --check dev_tools/build_file_parsing_util.py dev_tools/check_rule_has_tag.py dev_tools/check_forbidden_tags.py tests/test_build_file_parsing_util.py tests/test_check_rule_has_tag.py tests/test_check_forbidden_tags.pyuv run --with ty ty check dev_tools/build_file_parsing_util.py dev_tools/check_rule_has_tag.py dev_tools/check_forbidden_tags.py tests/test_build_file_parsing_util.py tests/test_check_rule_has_tag.py tests/test_check_forbidden_tags.pyuv run check-forbidden-tags --forbidden-tag=no-remote