Merged
Conversation
…er stack, etc.) is now thread-local.
hoffstadt
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: Thread-local state
assignees: ''
Description:
This PR makes internal state thread-local so that multiple threads calling DPG functions do not interfere with each other.
Without this fix, if two threads start creating a massive piece of GUI each (think of loading data into a table in two different windows), they will mess up the container stack and the app will eventually crash trying to add an item to an incompatible parent from another thread.
With this PR, multiple threads can safely use the following functions in parallel:
last_item,last_container,last_rootpush_container_stack,pop_container_stack,top_container_stack,empty_container_stackwith item...)capture_next_itemgenerate_uuid(in fact, used on creation of any item).The last item info, the container stack, and captured item are now thread-local.
Concerning Areas:
None.