feat(command): submit PR time via @holdex bot#113
Conversation
WalkthroughAdds documentation for a new Changessubmit-time command documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
|
@holdex pr submit-time 11m |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/commands/submit-time.md:
- Around line 23-27: The command uses an undefined <owner/repo> and
unnecessarily requires a PR number; instead take the PR `url` from the JSON
produced earlier (the `url` field referenced on line 16) and call gh pr comment
with that URL: replace the current gh pr comment <number> --repo <owner/repo>
--body "@holdex pr submit-time $ARGUMENTS" invocation with gh pr comment
<PR_URL> --body "@holdex pr submit-time $ARGUMENTS", then confirm the comment
posted and display the PR URL.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0bfbdc0f-1932-4e67-9a2a-9d3ebc5ee997
📒 Files selected for processing (1)
.claude/commands/submit-time.md
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.claude/commands/submit-time.md (1)
16-24:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd instructions for extracting the URL from JSON.
The JSON output on line 16 includes a
urlfield, but there's no instruction on how to extract it before using<PR_URL>on line 24.📝 Add extraction step
gh pr list --head "$(git branch --show-current)" --json number,url,title --limit 1+Extract the
urlfield from the JSON output above.
+
If no PR is found for the current branch, ask the user for the PR number or URL.Post the comment
</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In @.claude/commands/submit-time.md around lines 16 - 24, The gh pr list command
returns JSON including a url field but the script never extracts it; update the
flow so after running gh pr list --json number,url,title you extract the first
result's url (for example using gh's --jq to select .[0].url or piping the JSON
to jq and selecting .[0].url) and save that value as PR_URL, then pass that
PR_URL into gh pr comment; reference the gh pr list invocation and the gh pr
comment step when making this change.</details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.Duplicate comments:
In @.claude/commands/submit-time.md:
- Around line 16-24: The gh pr list command returns JSON including a url field
but the script never extracts it; update the flow so after running gh pr list
--json number,url,title you extract the first result's url (for example using
gh's --jq to select .[0].url or piping the JSON to jq and selecting .[0].url)
and save that value as PR_URL, then pass that PR_URL into gh pr comment;
reference the gh pr list invocation and the gh pr comment step when making this
change.</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `8ae0ef50-dcba-4217-ab31-04d05b199ec8` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 37438fe829d15f15bb5023472f80d989b8a8a835 and fcb1c94f39e4dc6361848a5bedd8bc2635e9313c. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `.claude/commands/submit-time.md` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Adds a global
/submit-timeClaude Code command that posts@holdex pr submit-time <time>on the current PR.Summary by CodeRabbit