-
Notifications
You must be signed in to change notification settings - Fork 225
chore(profile): add profile for Piyush Singh #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: PIYUSH RAJ SINGH <95915361+piyushuiux@users.noreply.github.com>
|
Warning Rate limit exceeded@tiffmyaaw has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 6 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
""" WalkthroughA new entry was added to the "team_profiles" array in the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
profile-submission.json (1)
112-117: New profile entry looks good; please align indentation with existing entries.The new object’s keys are indented by 5 spaces, whereas the rest of the file uses 6 spaces for object properties. Consistent indentation helps maintain readability and prevents JSON formatting tools from raising issues.
Apply this diff to fix the indent level:- { - "github_handle": "piyushuiux", - "full_name": "Piyush Raj Singh", - "github_trial_issue_link": "https://github.com/holdex/trial/issues/288" - } + { + "github_handle": "piyushuiux", + "full_name": "Piyush Raj Singh", + "github_trial_issue_link": "https://github.com/holdex/trial/issues/288" + }
tiffmyaaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update your PR description and title to match our Guidelines.
Your PR description should link your PR to your issue.
Don't forget to submit your time spent on the PR Time Tracker afterwards.
|
Resolves #288 |
It should be on the PR description, and use |
Signed-off-by: PIYUSH RAJ SINGH <95915361+piyushuiux@users.noreply.github.com>
Time Submission Status
|
|
closes #478 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename your PR title and description based on our Guidelines
Edit the PR description to link your issue manually.
Resolve the conflicts too.
If you're confused just look at the successfully closed PRs in this repo.
See here for examples to compare with yours |
|
@tiffmyaaw please review. |
tiffmyaaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual linking is still missing. If you're not sure yet don't ask for a review.
We have our code of conduct and core values:
- Ensure the quality of your work. It is a sign of poor ownership and lack of confidence when you expect someone to deal with your incomplete work.
“Own it with Passion” – we believe in taking ownership and responsibility for our work. We encourage a mindset of accelerated learning as you “figure it out yourself” and the drive to go beyond expectations. We are passionate about what we do and understand that the success of our business is dependent on us.
This needs to be in the description not here |
|
@tiffmyaaw I am unsure how to link manually, so please guide me. |
@piyushuiux you've done it correctly. Now we need to resolve the conflicts. |
Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>
closes #478
Summary by CodeRabbit