Skip to content

Conversation

@piyushuiux
Copy link
Contributor

@piyushuiux piyushuiux commented Apr 22, 2025

closes #478

Summary by CodeRabbit

  • New Features
    • Added a new team profile for "Piyush Raj Singh" to the team directory.

Signed-off-by: PIYUSH RAJ SINGH <95915361+piyushuiux@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 22, 2025

Warning

Rate limit exceeded

@tiffmyaaw has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 6 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1698f93 and b699a34.

📒 Files selected for processing (1)
  • profile-submission.json (1 hunks)

"""

Walkthrough

A new entry was added to the "team_profiles" array in the profile-submission.json file. The entry includes the GitHub handle "piyushuiux," the full name "Piyush Raj Singh," and a link to a related GitHub trial issue. No other entries or parts of the file were changed.

Changes

File(s) Change Summary
profile-submission.json Added a new team profile entry for "piyushuiux" with name and associated GitHub trial issue link.

Possibly related PRs

Suggested reviewers

  • tiffmyaaw
    """
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
profile-submission.json (1)

112-117: New profile entry looks good; please align indentation with existing entries.

The new object’s keys are indented by 5 spaces, whereas the rest of the file uses 6 spaces for object properties. Consistent indentation helps maintain readability and prevents JSON formatting tools from raising issues.
Apply this diff to fix the indent level:

-    {
-     "github_handle": "piyushuiux",
-     "full_name": "Piyush Raj Singh",
-     "github_trial_issue_link": "https://github.com/holdex/trial/issues/288"
-    }
+    {
+      "github_handle": "piyushuiux",
+      "full_name": "Piyush Raj Singh",
+      "github_trial_issue_link": "https://github.com/holdex/trial/issues/288"
+    }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af53749 and ddc02fe.

📒 Files selected for processing (1)
  • profile-submission.json (1 hunks)

Copy link
Contributor

@tiffmyaaw tiffmyaaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your PR description and title to match our Guidelines.
Your PR description should link your PR to your issue.

Don't forget to submit your time spent on the PR Time Tracker afterwards.

@piyushuiux
Copy link
Contributor Author

Resolves #288

@tiffmyaaw
Copy link
Contributor

Resolves #288

It should be on the PR description, and use Closes for issues in the same repo

Signed-off-by: PIYUSH RAJ SINGH <95915361+piyushuiux@users.noreply.github.com>
@holdex
Copy link

holdex bot commented May 24, 2025

Time Submission Status

Member Status Time Action Last Update
tiffmyaaw ✅ Submitted 10min Update time Dec 13, 2025, 4:52 AM
piyushuiux ✅ Submitted 20min Update time Dec 13, 2025, 4:52 AM

@piyushuiux
Copy link
Contributor Author

piyushuiux commented May 24, 2025

closes #478

Copy link
Contributor

@tiffmyaaw tiffmyaaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename your PR title and description based on our Guidelines

Edit the PR description to link your issue manually.

Resolve the conflicts too.

If you're confused just look at the successfully closed PRs in this repo.

@tiffmyaaw
Copy link
Contributor

Possibly related PRs

See here for examples to compare with yours

@piyushuiux piyushuiux changed the title [Product Designer] Piyush Raj Singh chore(profile): add profile for Piyush Singh May 25, 2025
@piyushuiux
Copy link
Contributor Author

@tiffmyaaw please review.

Copy link
Contributor

@tiffmyaaw tiffmyaaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual linking is still missing. If you're not sure yet don't ask for a review.

We have our code of conduct and core values:

  1. Ensure the quality of your work. It is a sign of poor ownership and lack of confidence when you expect someone to deal with your incomplete work.

“Own it with Passion” – we believe in taking ownership and responsibility for our work. We encourage a mindset of accelerated learning as you “figure it out yourself” and the drive to go beyond expectations. We are passionate about what we do and understand that the success of our business is dependent on us.

@tiffmyaaw
Copy link
Contributor

closes #478

This needs to be in the description not here

@piyushuiux
Copy link
Contributor Author

@tiffmyaaw I am unsure how to link manually, so please guide me.

@tiffmyaaw
Copy link
Contributor

tiffmyaaw commented May 26, 2025

@tiffmyaaw I am unsure how to link manually, so please guide me.

@piyushuiux you've done it correctly. Now we need to resolve the conflicts.

@tiffmyaaw tiffmyaaw enabled auto-merge (squash) May 26, 2025 14:55
tiffmyaaw
tiffmyaaw previously approved these changes Dec 13, 2025
Signed-off-by: Tiffany V. Y.  <116727382+tiffmyaaw@users.noreply.github.com>
@tiffmyaaw tiffmyaaw merged commit e39b5c7 into holdex:main Dec 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Product Designer] Piyush Singh

2 participants