chore(profile): add Andrew Mazhaev #387
Conversation
Signed-off-by: Andrew Mazhaev <mazhaev88@gmail.com>
Add profile for Andrew Mazhaev Signed-off-by: Andrew Mazhaev <mazhaev88@gmail.com>
|
""" WalkthroughA new team profile entry for "Andrew Mazhaev" was inserted into the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
profile-submission.json (2)
143-148: Align indentation with existing entries
To maintain consistent formatting, adjust the new object’s indentation to match other items in the array:
- Opening/closing braces should be indented 4 spaces.
- Object properties should be indented 6 spaces.
151-151: Remove extra blank lines at EOF
There are extra blank lines after the closing}. Retain exactly one newline at end-of-file to keep the diff clean.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
profile-submission.json(1 hunks)
🔇 Additional comments (1)
profile-submission.json (1)
143-148: New profile entry added correctly
TheandrewMazhaevobject includes all required fields (github_handle,full_name,github_trial_issue_link) and is properly inserted at the end of theteam_profilesarray without breaking JSON syntax.
Time Submission Status
|
tiffmyaaw
left a comment
tiffmyaaw
left a comment
There was a problem hiding this comment.
Please rename your PR title and description based on our Guidelines
Also edit the PR description to link your issue manually.
Good luck!
andrewMazhaev
changed the title
andrewMazhaev
changed the title
Signed-off-by: Andrew Mazhaev <mazhaev88@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
profile-submission.json(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
profile-submission.json
[error] 149-149: expected , but instead found {
Remove {
(parse)
[error] 154-154: expected ] but instead the file ends
the file ends here
(parse)
Resolved invalid JSON structure by: - Adding a comma after my profile block - Closing the team_profiles array and the root object Signed-off-by: Andrew Mazhaev <mazhaev88@gmail.com>
|
Hi @tiffmyaaw, This was my first time working with a PR like this, so it took me a bit of learning to figure everything out. |
only the manual link to issue is missing on your PR description |
|
It is done @tiffmyaaw |
not yet seen in the PR description. Did you check other successfully closed PRs? |
andrewMazhaev
changed the title
|
I checked out other members' successful PRs and did the same in my PR. Check if everything is correct now? @tiffmyaaw |
|
Also let me know why this needs to be done? |
We need to make sure you'll be able to work within our working environment and Guidelines, as your work will mostly within GH. |
|
Are you saying that I will be working mostly in GH and not Figma? That doesn't make sense @tiffmyaaw |
All of your work reports within our organization will need to be on GH. We also have a designer team here and they use Figma, they also update their progress on GH. |
* Update profile-submission.json Signed-off-by: Andrew Mazhaev <mazhaev88@gmail.com> * Update profile-submission.json Add profile for Andrew Mazhaev Signed-off-by: Andrew Mazhaev <mazhaev88@gmail.com> * Fix JSON syntax: added comma and closing brackets Resolved invalid JSON structure by: - Adding a comma after my profile block - Closing the team_profiles array and the root object Signed-off-by: Andrew Mazhaev <mazhaev88@gmail.com> --------- Signed-off-by: Andrew Mazhaev <mazhaev88@gmail.com>
2 participants
Closes #361
Add profile for Andrew Mazhaev
Summary by CodeRabbit