-
Notifications
You must be signed in to change notification settings - Fork 225
chore(profile): add profile for Fikri Izzuddin #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds one new team profile entry to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
profile-submission.json (1)
333-338: Optional: add a lightweight schema/dup-check in CITo prevent future typos/dup handles, add a CI step that validates:
- keys: github_handle, full_name, github_trial_issue_link
- unique github_handle
- issue link pattern: https://github.com/holdex/trial/issues/
I can provide a tiny Python or jq script for this if you want it in the repo.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
profile-submission.json(1 hunks)
🔇 Additional comments (2)
profile-submission.json (2)
333-338: LGTM: well-formed JSON and correct placementEntry matches the existing schema, commas/braces are correct, and the last element has no trailing comma.
335-337: Verified trial issue link references correct handle
Issue #928 was opened by @oyi77 (Muchammad Fikri Izzuddin). cite1
Time Submission Status
|
tiffmyaaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
First commit missing
verifiedhandle. Kindly follow this instruction to verify past commits. -
Rename your PR title and description based on our Guidelines
-
Edit the PR description to link your issue manually.
-
Last, update your time spent on the PR Time Tracker bot.
Signed-off-by: Paijo <14921983+oyi77@users.noreply.github.com>
|
@tiffmyaaw I have updated this PR to do what you asked for. Thank you for the review |
tiffmyaaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the manual linking for issues within the same repo
Signed-off-by: Paijo <14921983+oyi77@users.noreply.github.com>

Closes #928
This pull request adds a new profile entry to the
profile-submission.jsonfile.oyi77(Muchammad Fikri Izzuddin), including their GitHub trial issue link.Summary by CodeRabbit