Skip to content

Conversation

@oyi77
Copy link
Contributor

@oyi77 oyi77 commented Sep 6, 2025

Closes #928
This pull request adds a new profile entry to the profile-submission.json file.

  • Added a new user, oyi77 (Muchammad Fikri Izzuddin), including their GitHub trial issue link.

Summary by CodeRabbit

  • New Features
    • Added a new team profile for Muchammad Fikri Izzuddin (GitHub: oyi77). The profile will appear in team listings, selection interfaces, and attribution screens, improving discoverability of the new member. No other profiles or behaviors were changed; no downtime or configuration required.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 6, 2025

Walkthrough

Adds one new team profile entry to profile-submission.json under team_profiles: github_handle "oyi77", full_name "Muchammad Fikri Izzuddin", github_trial_issue_link "#928". No other files or logic changed.

Changes

Cohort / File(s) Summary
Team profiles data update
profile-submission.json
Inserted a new object into the team_profiles array: {"github_handle":"oyi77","full_name":"Muchammad Fikri Izzuddin","github_trial_issue_link":"https://github.com/holdex/trial/issues/928"}

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • tiffmyaaw

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore(profile): add profile for Fikri Izzuddin" is concise, follows a conventional prefix, and accurately summarizes the primary change of adding a profile entry for the named applicant in this changeset.
Linked Issues Check ✅ Passed The PR adds a profile object for Muchammad Fikri Izzuddin to profile-submission.json with github_handle, full_name, and github_trial_issue_link and the PR description states it closes issue #928, so it implements the linked issue's primary coding objective of adding the applicant's profile; the change is a data-only insertion and does not alter code logic. If the repository's profile schema requires additional metadata from the issue (for example telegram, portfolio, or LinkedIn), those fields are not present in this entry and should be added only if mandated by project conventions.
Out of Scope Changes Check ✅ Passed Only profile-submission.json was modified and the change is a single data insertion of a team profile entry; there are no modifications to code, configuration, or other files that would indicate out-of-scope changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0d2ba4 and 7288a96.

📒 Files selected for processing (1)
  • profile-submission.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • profile-submission.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
profile-submission.json (1)

333-338: Optional: add a lightweight schema/dup-check in CI

To prevent future typos/dup handles, add a CI step that validates:

I can provide a tiny Python or jq script for this if you want it in the repo.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe5341c and 8e5d4ee.

📒 Files selected for processing (1)
  • profile-submission.json (1 hunks)
🔇 Additional comments (2)
profile-submission.json (2)

333-338: LGTM: well-formed JSON and correct placement

Entry matches the existing schema, commas/braces are correct, and the last element has no trailing comma.


335-337: Verified trial issue link references correct handle
Issue #928 was opened by @oyi77 (Muchammad Fikri Izzuddin). cite1

@holdex
Copy link

holdex bot commented Sep 6, 2025

Time Submission Status

Member Status Time Action Last Update
oyi77 ✅ Submitted 8min Update time Sep 23, 2025, 2:18 PM
tiffmyaaw ✅ Submitted 7min Update time Sep 23, 2025, 2:18 PM

Copy link
Contributor

@tiffmyaaw tiffmyaaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. First commit missing verified handle. Kindly follow this instruction to verify past commits.

  2. Rename your PR title and description based on our Guidelines

  3. Edit the PR description to link your issue manually.

  4. Last, update your time spent on the PR Time Tracker bot.

Signed-off-by: Paijo <14921983+oyi77@users.noreply.github.com>
@oyi77 oyi77 changed the title feat(profile): profile submission chore(profile): add profile for Fikri Izzuddin Sep 11, 2025
@oyi77
Copy link
Contributor Author

oyi77 commented Sep 11, 2025

@tiffmyaaw I have updated this PR to do what you asked for. Thank you for the review

Copy link
Contributor

@tiffmyaaw tiffmyaaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the manual linking for issues within the same repo

@oyi77
Copy link
Contributor Author

oyi77 commented Sep 23, 2025

Use the manual linking for issues within the same repo

this should be done this
image

Signed-off-by: Paijo <14921983+oyi77@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Full-Stack Enginer, Web3] Muchammad Fikri Izzuddin

2 participants