GraphQL update operation not possible

[maxschmeling]

Updating objects using the GraphQL interface seems to be broken because of this line:

jsonapi-server/lib/graphQl/resolvers.js

Line 33 in c682291

const path = `${jsonApi._apiConfig.pathPrefix + resourceConfig.resource}/${args.tags.id}`

It references args.tags.id. args.tags is undefined.

Is this something I'm missing because I'm extremely new to GraphQL or is this just completely broken? It seems like tags should be something dynamic based on the schema.

[pmcnr-hx]

Can you provide a specific example that is failing? We have some tests covering GraphQL updates, which are passing, so it's hard to believe it broken for all cases.

[maxschmeling]

I believe it will fail anytime resourceConfig.resource is not tags. I could be missing something, but it seems hard-coded to work only for a resource called tags.

[maxschmeling]

If I change

const path = `${jsonApi._apiConfig.pathPrefix + resourceConfig.resource}/${args.tags.id}`

to

const path = `${jsonApi._apiConfig.pathPrefix + resourceConfig.resource}/${args[resourceConfig.resource].id}`

then my updates work.

[pmcnr-hx]

Thanks for the clarification @maxschmeling. I'll take a better look at the code and I'll come back to you.

[pmcnr-hx]

You are absolutely correct @maxschmeling. GraphQL support is still a bit immature and indeed the above was hardcoded for our automated tests which explained why the test passed. Would you like to submit a PR with the fix you propose above, so you get the credit? If not I can do it myself, but I would prefer if the commit came from you.

Thanks again for reporting the issue, diagnosing the problem and coming up with a fix and helping improve jsonapi-server.

[maxschmeling]

Awesome. Glad I could help.

I'll put together a PR today.