Parse and joi validate search filter: update changelog and bump version #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract individual filter validations into helper functions for more modular and readable code.
We only meant to skip validation for nested filters, but we were actually skipping array values (multiple values for a property) which should not be skipped.
Filters should always be valid when we get to the post-processing stage so remove the redundant check.
Parse and validate using Joi the filter elements, so this work is only done in one place and the parsed filters can be provided to the handlers, avoid the need to redo that work there as is currently needed.
The test was passing previously by accident. Once the filter is corrected to include a valid email address, it breaks because the filter isn't being passed to the related resource rerouted request. Fix the test and pass the query string (including the filter) to related resources.
The more generic nature of its functionality warrants the rename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #131 for review.
Updating changelog and bumping version for release.