Export module version. #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export module version so data store modules can check for the minimum required server version.
pmcnr-hx
force-pushed
the
export-module-version
branch
from
488c9fa to
ca38098
Compare
| /* @flow weak */ | ||
| "use strict"; | ||
| var jsonApi = module.exports = { }; | ||
| jsonApi._version = require(require("path").join(__dirname, "../package.json")).version; |
There was a problem hiding this comment.
process.env.npm_package_version is a nicer way to get this.
Contributor
Author
There was a problem hiding this comment.
It would definitely be nicer, but unfortunately I need this the be the required package version when I require it in the data stores. 😞 process.env.npm_package_version would give me the main package's version.
Contributor
|
👍 Nice one! |
|
👍 |
|
taking 3️⃣ |
|
looks good 👍 |
pmcnr-hx
force-pushed
the
export-module-version
branch
from
2ba05c6 to
c135933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export module version so data store modules can check for the minimum required server version.
Also take the opportunity to update to latest dependencies.