Conversation
TomFirth
approved these changes
Dec 28, 2017
JordanHood
commented
Jan 2, 2018
| } | ||
|
|
||
| request.server.inject({ | ||
| const response = await request.server.inject({ |
Member
Author
There was a problem hiding this comment.
not to sure if this needs wrapping in a try catch block,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? (please provide any background)
https://hxshortbreaks.atlassian.net/browse/NB-699
this updates this plugin to work on hapi v17
What tests does this PR have?
How can this be tested?
see https://github.com/holidayextras/the-works/pull/705
Any tech debt?
Screenshots / Screencast
What gif best describes how you feel about this work?
By approving a review you are confirming you have...