Skip to content

date fixes for some US states#289

Merged
ppeble merged 1 commit intoholidays:masterfrom
philipwritescode:holidays-missing-from-definitions
Mar 29, 2026
Merged

date fixes for some US states#289
ppeble merged 1 commit intoholidays:masterfrom
philipwritescode:holidays-missing-from-definitions

Conversation

@philipwritescode
Copy link
Copy Markdown

Fixes for:

Mardi Gras in AL

Confederate Memorial Day in AL (4th monday)

Good Friday in PA

Arbor Day in NE (change calculation to Last Friday)

Election Day in LA

Comment thread us.yaml
function_modifier: -47
- name: Mardi Gras Day
regions: [us_la]
regions: [us_al, us_la]
Copy link
Copy Markdown
Author

@philipwritescode philipwritescode Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mardi Gras Day (only in Baldwin and Mobile Counties) (Personal Leave Day will be granted for all other counties.)

https://admincode.legislature.state.al.us/administrative-code/670-X-12-.01

Comment thread us.yaml
type: informal
- name: Good Friday # public holiday in the following states
regions: [us_ct, us_de, us_gu, us_hi, us_in, us_ky, us_la, us_nj, us_nc, us_nd, us_pr, us_tn]
regions: [us_ct, us_de, us_gu, us_hi, us_in, us_ky, us_la, us_nj, us_nc, us_nd, us_pa, us_pr, us_tn]
Copy link
Copy Markdown
Author

@philipwritescode philipwritescode Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread us.yaml
Comment on lines +163 to +166
- name: Confederate Memorial Day # 4th Monday in April
regions: [us_al]
week: 4
wday: 1
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread us.yaml
Comment on lines +174 to +177
- name: Arbor Day
regions: [us_ne]
mday: 28
week: -1
wday: 5
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread us.yaml
Comment on lines +276 to +278
- name: Election Day # even years only
regions: [us_la]
function: even_year_election_day(year)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Election Day | Tuesday, after the first Monday in November, every two years

https://www.lpsc.louisiana.gov/DNC_Holidays

@philipwritescode philipwritescode marked this pull request as ready for review September 13, 2024 14:13
@philipwritescode
Copy link
Copy Markdown
Author

@ppeble could you review this and consider merging? Let me know if you have any feedback

Copy link
Copy Markdown

@wleeper wleeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well documented change

@philipwritescode
Copy link
Copy Markdown
Author

@ppeble Election day is coming up and this change will help in LA. Do you know when you could review?

@philipwritescode
Copy link
Copy Markdown
Author

Election day is coming up and this change will help in LA.

Just realized this reads like some political spam, lol

Copy link
Copy Markdown
Member

@ppeble ppeble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ppeble ppeble merged commit 85c267d into holidays:master Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants