bgp: fixes sizing checks on attribute.rs file in BGP #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@rwestphal whenever the size check fails, I always returned an I'd like a check from you if there is anywhere that `Withdraw would have been preferred, before I change this to ready for review. This is also branched from |
Issues raised by fuzzing mainly involved size checks of packets that are being decoded. This commit fixes those issues in the holo-bgp/src/packet/message.rs file. Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
Paul-weqe
force-pushed
the
bgp-attr-fuzz-fixes
branch
from
52b1b39 to
ed24f96
Compare
- add tests for: * Attr decode * AsPathSegment decode * MpReachNlri decode - fix decode asn Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
Paul-weqe
force-pushed
the
bgp-attr-fuzz-fixes
branch
from
ed24f96 to
27b56bf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bgp: add tests and fixes for attribute decoders
add tests for:
Fixes the issues that had been raised due to the tests above failing.
Issues in these tests were yet again raised due to fuzzing.