Added onlychanged flag for watch method #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
reviewed
Sep 24, 2018
| self_._watch('remove',watcher,parameter_name,parameter_attribute) | ||
| unwatched = True | ||
| except: pass | ||
| for onlychanged in [True, False]: |
There was a problem hiding this comment.
Are the watchers hashed based on their onlychanged value or why is this necessary?
There was a problem hiding this comment.
Okay I see it, I'm happy to merge now but maybe we could consider changing the watchers to be a nested dict with keys of the form watchers[parameter_name][(parameter_attribute, fn)]. That way you don't need to replicate the whole watcher state on unwatch.
There was a problem hiding this comment.
This is so named tuples match when removing from a list. If the value is different for onlychanged then it won't match. The alternative is to specify onlychanged as an argument which will only remove that type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided we wanted this boolean option independently of whether we implement the
triggermethod or not.