Allow unknown TLVs to pass through#224
Conversation
|
This will also fix home-assistant/addons#4357 |
|
Would be amazing, if this can be merged/releases rather quickly since my boarder router does not work because of this issue and I can't use my matter via thread devices. Thanks! |
|
I've tried to patch my live installation with this and run into this exception instead. UPDATE: I think this has to do with the fact that my OTBR docker instance had dropped it's active dataset entirely and reconfiguring via the UI didn't reapply it, however, manually setting the active dataset to the backed up value via |
There was a problem hiding this comment.
Why do we modify the existing tests instead of adding new tests?
Also, is all the the new code covered by tests?
Edit: The only added code not covered is the handling of duplicated tags
|
|
||
| # Once we have the value, we can log a warning about the unknown TLV | ||
| if not isinstance(tag, MeshcopTLVType): | ||
| _LOGGER.warning("unknown TLV type %d=%r", raw_tag, val) |
There was a problem hiding this comment.
Considering the point of the PR it to let unknown tags pass through, I'm not sure we should log a warning? I'd suggest to lower severity to debug since this shouldn't matter to the user.
|
I discussed this with @puddly and we decided to merge this PR as is and improve the tests in a follow-up to ensure this PR is included in Home Assistant Core 2026.2.0 which is released tomorrow. |
Unknown TLVs should not be a hard parsing failure (in this case we were missing
DURATION = 23), they are inevitable and the TLV structure allows them to be passed through and re-serialized untouched.#209 will add the missing TLVs.