Add modelable ingress APIs to client library#290
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Supervisor ingress endpoints with typed models to aiohasupervisor, enabling core to use the modelable ingress APIs (notably /ingress/panels, plus session endpoints).
Changes:
- Introduces
IngressClientwithpanels,create_session, andvalidate_sessionmethods. - Adds ingress response/request models and exports key types from
aiohasupervisor.models. - Adds fixtures and test coverage for the new ingress APIs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
aiohasupervisor/ingress.py |
New component client implementing the ingress endpoints. |
aiohasupervisor/models/ingress.py |
New dataclass models for ingress responses/options. |
aiohasupervisor/root.py |
Wires IngressClient into SupervisorClient as .ingress. |
aiohasupervisor/models/__init__.py |
Re-exports ingress models for public consumption. |
tests/test_ingress.py |
Adds tests for the new ingress APIs. |
tests/fixtures/ingress_panels.json |
Fixture for /ingress/panels response. |
tests/fixtures/create_session.json |
Fixture for /ingress/session response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MartinHjelmare
approved these changes
Mar 19, 2026
agners
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for modelable ingress APIs in Supervisor to the client library. This is mainly to include support for the
/ingress/panelsAPI in the library as its needed in core./ingress/sessionand/ingress/validate_sessionwere added for completeness since they are modelable.The wildcard proxy endpoint is intentionally omitted as it isn't modelable and only intended for use by core. We won't use the library for that one.