Skip to content

Add modelable ingress APIs to client library#290

Merged
agners merged 2 commits intomainfrom
add-ingress-apis
Mar 19, 2026
Merged

Add modelable ingress APIs to client library#290
agners merged 2 commits intomainfrom
add-ingress-apis

Conversation

@mdegat01
Copy link
Copy Markdown
Collaborator

@mdegat01 mdegat01 commented Mar 18, 2026

Proposed Changes

Add support for modelable ingress APIs in Supervisor to the client library. This is mainly to include support for the /ingress/panels API in the library as its needed in core. /ingress/session and /ingress/validate_session were added for completeness since they are modelable.

The wildcard proxy endpoint is intentionally omitted as it isn't modelable and only intended for use by core. We won't use the library for that one.

@mdegat01 mdegat01 requested a review from agners March 18, 2026 17:23
@agners agners requested a review from Copilot March 18, 2026 17:28
@mdegat01 mdegat01 added the new-feature New features or options. label Mar 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Supervisor ingress endpoints with typed models to aiohasupervisor, enabling core to use the modelable ingress APIs (notably /ingress/panels, plus session endpoints).

Changes:

  • Introduces IngressClient with panels, create_session, and validate_session methods.
  • Adds ingress response/request models and exports key types from aiohasupervisor.models.
  • Adds fixtures and test coverage for the new ingress APIs.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
aiohasupervisor/ingress.py New component client implementing the ingress endpoints.
aiohasupervisor/models/ingress.py New dataclass models for ingress responses/options.
aiohasupervisor/root.py Wires IngressClient into SupervisorClient as .ingress.
aiohasupervisor/models/__init__.py Re-exports ingress models for public consumption.
tests/test_ingress.py Adds tests for the new ingress APIs.
tests/fixtures/ingress_panels.json Fixture for /ingress/panels response.
tests/fixtures/create_session.json Fixture for /ingress/session response.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_ingress.py
Comment thread tests/test_ingress.py Outdated
Comment thread aiohasupervisor/ingress.py
@agners agners merged commit 9a9bee8 into main Mar 19, 2026
12 checks passed
@agners agners deleted the add-ingress-apis branch March 19, 2026 13:10
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new-feature New features or options.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants