Handle unrecognized notification types #360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new CC notification was added at some point but because of the way we handled it, it created an error upstream. In this case we catch the error and report it with a more clear message.
Notification event in question: https://zwave-js.github.io/node-zwave-js/#/api/node?id=powerlevel-cc
I wanted to know, do we want to issue a patch release with this fix? If so I can target a new branch and release from that one before merging that branch into
master(we have to do this instead of releasing frommasterso we don't force users to update the server until the next release). I can't decide since we raise an exception either way (currently the HA code raises an exception because we try to access a property that doesn't exist).Another point not as important but worth mentioning - I'm going to add graceful handling of unsupported notification CC's in HA but I can't do that until this bug is fixed