Skip to content

Conversation

@raman325
Copy link
Contributor

@raman325 raman325 commented Feb 10, 2022

A new CC notification was added at some point but because of the way we handled it, it created an error upstream. In this case we catch the error and report it with a more clear message.

Notification event in question: https://zwave-js.github.io/node-zwave-js/#/api/node?id=powerlevel-cc

I wanted to know, do we want to issue a patch release with this fix? If so I can target a new branch and release from that one before merging that branch into master (we have to do this instead of releasing from master so we don't force users to update the server until the next release). I can't decide since we raise an exception either way (currently the HA code raises an exception because we try to access a property that doesn't exist).

Another point not as important but worth mentioning - I'm going to add graceful handling of unsupported notification CC's in HA but I can't do that until this bug is fixed

@MartinHjelmare
Copy link
Contributor

Do we have user reports affected by this problem? If there's still an error raised regardless, it doesn't seem worth a patch release from different branch.

@raman325
Copy link
Contributor Author

Do we have user reports affected by this problem? If there's still an error raised regardless, it doesn't seem worth a patch release from different branch.

@kpine came across it but we've only had one report and to your point, nothing bad happens, there's an error, so I agree

@raman325 raman325 merged commit 4abc5c0 into home-assistant-libs:master Feb 10, 2022
@raman325 raman325 deleted the notification_handling branch February 10, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants