Changes in controler association functions #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async_get_associations,
async_is_association_allowed,
async_add_associations,
async_remove_associations:
No allows AssociationAddress as Source (nodeid + (optional)endpoint)
Fix: async_get_associations:
missing that a list of associations reported in a group
Fix: async_is_association_allowed,
async_add_associations,
async_remove_associations:
Now make a different between association with and without endpoint.
As for some devices "nodeId=x endpoint=0" is not the same as "nodeid=x"
:
Contributor
|
@Dummy0815 you need to increase the code coverage on this PR. If you click details next to the failed CI step, it will show you exactly what parts of the code aren't covered with tests. |
raman325
reviewed
Mar 15, 2022
raman325
reviewed
Mar 15, 2022
Contributor
|
@Dummy0815 are you planning to update this PR so we can finish reviewing it and merge? |
raman325
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: async_get_association_groups,
async_get_associations,
async_is_association_allowed,
async_add_associations,
async_remove_associations:
No allows Assocation (AssociationAddress) as Source (nodeid + (optional)endpoint)
Fix: async_get_associations:
missing that a list of associations reported in a group
Fix: async_is_association_allowed,
async_add_associations,
async_remove_associations:
Now make a different between association with and without endpoint.
As for some devices "nodeId=x endpoint=0" is not the same as "nodeid=x"