Skip to content

Introduce ServerSessionManager to handle auth and session state#6380

Merged
TimoPtr merged 2 commits intomainfrom
feature/server_session_manager
Feb 12, 2026
Merged

Introduce ServerSessionManager to handle auth and session state#6380
TimoPtr merged 2 commits intomainfrom
feature/server_session_manager

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Feb 3, 2026

Summary

Checklist

I decided to split the auth/session management used in the WebView in a dedicated class to avoid creating a giant ViewModel. The idea is to have things related in the same manager and injected into the viewModel.

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Test Results

  146 files  + 1    146 suites  +1   8m 47s ⏱️ -6s
1 210 tests +10  1 210 ✅ +10  0 💤 ±0  0 ❌ ±0 
1 228 runs  +10  1 228 ✅ +10  0 💤 ±0  0 ❌ ±0 

Results for commit 367179b. ± Comparison against base commit c2e424c.

♻️ This comment has been updated with latest results.

@TimoPtr TimoPtr mentioned this pull request Feb 4, 2026
4 tasks
@TimoPtr TimoPtr added the WebViewActivity replacement Ongoing work to replace the WebViewActivity in favor of a well tested compose screen using nav. label Feb 4, 2026
@TimoPtr TimoPtr force-pushed the feature/external_bus_repository_v2 branch 4 times, most recently from 62a0442 to 103750e Compare February 11, 2026 12:06
@TimoPtr TimoPtr force-pushed the feature/server_session_manager branch from 367179b to 53b3890 Compare February 11, 2026 13:12
@TimoPtr TimoPtr requested a review from jpelgrom February 11, 2026 13:14
Base automatically changed from feature/external_bus_repository_v2 to main February 12, 2026 09:14
@TimoPtr TimoPtr force-pushed the feature/server_session_manager branch from 53b3890 to 6a463a1 Compare February 12, 2026 09:16
@TimoPtr TimoPtr merged commit 6889af9 into main Feb 12, 2026
23 checks passed
@TimoPtr TimoPtr deleted the feature/server_session_manager branch February 12, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed WebViewActivity replacement Ongoing work to replace the WebViewActivity in favor of a well tested compose screen using nav.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants