Adjust LocationForSecureConnection wording#6509
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the onboarding/settings “LocationForSecureConnection” messaging so the screen can show different explanatory text depending on whether the server configuration includes any plain HTTP URLs.
Changes:
- Split the secure-connection explanatory string into a generic version and an HTTP-specific version.
- Add
hasPlainTextUrlwiring fromLocationForSecureConnectionViewModelinto the screen to choose the appropriate message. - Extend unit and screenshot coverage to validate the HTTP-specific variant.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| common/src/main/res/values/strings.xml | Adds a new HTTP-specific string and adjusts the generic content string. |
| app/src/main/kotlin/io/homeassistant/companion/android/onboarding/locationforsecureconnection/LocationForSecureConnectionViewModel.kt | Exposes hasPlainTextUrl as a new flow for the UI to branch on. |
| app/src/main/kotlin/io/homeassistant/companion/android/onboarding/locationforsecureconnection/LocationForSecureConnectionScreen.kt | Plumbs hasPlainTextUrl into the UI and selects the appropriate string resource. |
| app/src/test/kotlin/io/homeassistant/companion/android/onboarding/locationforsecureconnection/LocationForSecureConnectionScreenTest.kt | Adds a test case and updates expectations to account for the conditional text. |
| app/src/screenshotTest/kotlin/io/homeassistant/companion/android/onboarding/locationforsecureconnection/LocationForSecureConnectionScreenshotTest.kt | Adds a preview/screenshot scenario for the HTTP variant. |
...anion/android/onboarding/locationforsecureconnection/LocationForSecureConnectionViewModel.kt
Outdated
Show resolved
Hide resolved
...nion/android/onboarding/locationforsecureconnection/LocationForSecureConnectionScreenTest.kt
Show resolved
Hide resolved
Contributor
Test Results 94 files 94 suites 10m 53s ⏱️ Results for commit 56d389c. ♻️ This comment has been updated with latest results. |
jpelgrom
reviewed
Feb 26, 2026
jpelgrom
reviewed
Mar 4, 2026
| <string name="location_sharing_no_share">Do not share my location</string> | ||
| <string name="location_secure_connection_title">Let us help secure your remote connection</string> | ||
| <string name="location_secure_connection_content">It appears that your connection is not encrypted (using HTTP). If the app knows when you\'re away from home, it can choose a more secure way to connect to your Home Assistant system if available. This requires location services to be enabled.</string> | ||
| <string name="location_secure_connection_content_http">It appears that your connection is not encrypted (currently using HTTP).</string> |
Member
There was a problem hiding this comment.
The check from a technical view is 'does the server have any plain text url'. This text suggests you are currently using a plain text url.
Member
Author
There was a problem hiding this comment.
What about currently using HTTP in your configuration?
4 tasks
jpelgrom
approved these changes
Mar 16, 2026
Member
jpelgrom
left a comment
jpelgrom
left a comment
There was a problem hiding this comment.
Let's go with this for now and see if it helps reduce confusion
sk7n4k3d
pushed a commit
to sk7n4k3d/home-assistant-android
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjust the wording of the LocationForSecureConnection screen to match the current configuration and not a generic one that was missleading for some users.
Checklist