Skip to content

Make sure that manifest URL is using base url while checking#6530

Merged
jpelgrom merged 1 commit intomainfrom
fix/wrong_url_checks
Mar 4, 2026
Merged

Make sure that manifest URL is using base url while checking#6530
jpelgrom merged 1 commit intomainfrom
fix/wrong_url_checks

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Mar 4, 2026

Summary

While testing some error screen I found out that the manifest check was wrong because it was using the full URL given, where the manifest.json should only be checked on the base URL otherwise it doesn't work.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

I renamed the function, added some docs and test.

@TimoPtr TimoPtr requested review from Copilot and jpelgrom and removed request for Copilot March 4, 2026 11:06
@jpelgrom jpelgrom merged commit ce88f49 into main Mar 4, 2026
23 checks passed
@jpelgrom jpelgrom deleted the fix/wrong_url_checks branch March 4, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants