Remove the use of Dispachers.Default in AppLockViewModel#6784
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit use of Dispatchers.Default from AppLockViewModel.setAppActive, allowing the coroutine to use the viewModelScope context (Main dispatcher in production, test dispatcher in unit tests). This aligns the implementation with the fact that the invoked suspend work is already main-safe and eliminates flakiness caused by running on an uncontrolled dispatcher in tests.
Changes:
- Remove the
kotlinx.coroutines.Dispatchersimport fromAppLockViewModel - Launch
setAppActivework inviewModelScopewithout forcingDispatchers.Default
jpelgrom
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We were using the default dispatcher in the
AppLockViewModelbut it is not needed since the method called are Main safe already.Because of the usage of the default dispatcher the unit test of
setAppActiveis flaky https://github.com/home-assistant/android/actions/runs/24982874143/job/73151266819?pr=6776