Set compile SDK to 37#6871
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s compile SDK version to API 37 to prepare the Android build for upcoming platform changes, and adjusts a Robolectric/MockK unit test to remain compatible with the updated SDK method signatures.
Changes:
- Bump
androidSdk-compilefrom 36 → 37 in the version catalog. - Disambiguate
View.performHapticFeedback(...)mocking/verifications inHapticFeedbackPerformerTestby explicitly matching theIntoverload.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
gradle/libs.versions.toml |
Raises the compile SDK version used by the shared Android Gradle convention to API 37 |
app/src/test/kotlin/io/homeassistant/companion/android/frontend/haptic/HapticFeedbackPerformerTest.kt |
Fixes MockK matcher typing for performHapticFeedback(Int) to keep tests passing with the newer SDK |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In order to prepare the app to support Android API 37 this PR bumps the compile SDK to 37 and fix one issue that appear in the HapticPerformerTest due to some new API it needs a specific mocking type declaration.