Fix LocalStorage observeChanges ignores later keys#6902
Merged
TimoPtr merged 2 commits intoMay 26, 2026
Conversation
4 tasks
TimoPtr
reviewed
May 25, 2026
Member
TimoPtr
left a comment
There was a problem hiding this comment.
Thanks for catching this 👍🏻 it is my mistake ...
TimoPtr
approved these changes
May 26, 2026
observeChanges ignores later keysobserveChanges ignores later keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
LocalStorageImpl.observeChanges,awaitClosewas placed inside thekeys.forEachloop, the coroutine suspended after the first iteration, so the listeners for the remaining keys were never registered. The first key was effectively the only one observed, changes to later keys are ignored silently.This fix replaces the per-key listeners with a single listener that filters by the watched key set and registers/unregisters once.
Checklist