Build a dumb event.json instead of storing one#6912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on the code of the action to report test we don't need to have a full fledge
event.jsonfile it only requires some field to actually reports things. To avoid storing the file as an artifact I decided to build a very dumb one in the pr-emulator-wtf workflow. The downside is that we are loosing some cosmetic on the comments that is left on the PR like the ability to detect the numbers of test VS another run like +x tests, but it is acceptable.I've also noticed that the checks where under the group
CodeQL/*prefix unfortunately we cannot change it with the API of Github it might be something internally that does this.