Skip to content

Add link to actual job for the emulator wtf checks#6916

Merged
TimoPtr merged 1 commit into
mainfrom
feature/emulator_wtf_better_checks
May 28, 2026
Merged

Add link to actual job for the emulator wtf checks#6916
TimoPtr merged 1 commit into
mainfrom
feature/emulator_wtf_better_checks

Conversation

@TimoPtr
Copy link
Copy Markdown
Member

@TimoPtr TimoPtr commented May 28, 2026

Summary

The current limitations of the checks API makes that the Instrumentation Test app check doesn't show the real job and does not contains a link to it either. This PR build a link to the Job and add it to the check summary. I didn't do it for the test result because we already have a resume of the run and we could get there using the Instrumentation Test app link if we really want to.

It's not the best but it's best effort to get a usable experience. An issue remains is that if we re-run the Pull Request workflow it duplicates the external checks in the workflow.

Copilot AI review requested due to automatic review settings May 28, 2026 07:21
@TimoPtr TimoPtr merged commit 556fc24 into main May 28, 2026
6 of 7 checks passed
@TimoPtr TimoPtr deleted the feature/emulator_wtf_better_checks branch May 28, 2026 07:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the manually created "Instrumentation Test app" PR check in the pr-emulator-wtf.yml workflow to include a link back to the actual job page (and its logs). Because GitHub may rewrite details_url for API-created checks absorbed into PR-context check suites, the link is also embedded in output.summary as a reliable fallback. The current job's ID is resolved by querying the Actions jobs API and matching against RUNNER_NAME.

Changes:

  • Resolve the current job's numeric ID via the Actions jobs API (matched on runner_name == RUNNER_NAME), constructing a job_url with a safe fallback to the run URL.
  • Set output.summary with a Markdown deep-link to the emulator.wtf job on both check creation and finalization, switching from gh api -f flags to jq-built JSON payloads piped via --input -.
  • Persist job_url as a step output so the finalize step can reuse it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants