Skip to content

Correctly pin cosign-verify action in build-image action#281

Merged
sairon merged 1 commit intomasterfrom
fix-build-image-verify
Mar 17, 2026
Merged

Correctly pin cosign-verify action in build-image action#281
sairon merged 1 commit intomasterfrom
fix-build-image-verify

Conversation

@sairon
Copy link
Member

@sairon sairon commented Mar 17, 2026

The build-image action was using branch reference to the previous PR branch when calling the cosign-verify. It was pointed to that because when the actions are reused, the path is evaluated relative to the repo that's using them - so we can't simply use local path here. We've got unfortunately a chicken-egg situation then, so we must always pin the verify action to the previous release.

The build-image action was using branch reference to the previous PR branch
when calling the cosign-verify. It was pointed to that because when the actions
are reused, the path is evaluated relative to the repo that's using them - so
we can't simply use local path here. We've got unfortunately a chicken-egg
situation then, so we must always pin the verify action to the previous
release.
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got unfortunately a chicken-egg situation then, so we must always pin the verify action to the previous release.

Hm, yeah so essentially we cannot reuse a action from the same repo while also using version pinning (using version number or hash) 🤔 . A bit unfortunate. Maybe we should consider to split out the cosign-verify action? 🤔

Anyhow, for now, lagging one release behind works.

@sairon sairon merged commit 537e6bc into master Mar 17, 2026
7 checks passed
@sairon sairon deleted the fix-build-image-verify branch March 17, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants