Increase ha supervisor repair timeout to 1h

[agners]

This command potentially downloads containers. Use the default container download timeout of 1h.

Fixes: home-assistant/supervisor#5627

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the timeout for repair operations, ensuring the system waits an appropriate duration for responses during repair attempts. This update helps improve reliability by reducing the chance of premature timeouts during supervisor repairs.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change updates the timeout parameter used in the supervisor repair command. In the Run method of the supervisor repair command within cmd/supervisor_repair.go, the timeout passed to the GenericJSONPostTimeout function has been changed from helper.ContainerOperationTimeout to helper.ContainerDownloadTimeout.

Changes

File	Change Summary
cmd/supervisor_repair.go	Modified the timeout parameter in the Run method by replacing helper.ContainerOperationTimeout with helper.ContainerDownloadTimeout.

Sequence Diagram(s)

sequenceDiagram
    participant R as supervisorRepairCmd
    participant G as GenericJSONPostTimeout
    R->>G: Call with helper.ContainerDownloadTimeout
    G-->>R: Return response

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Ability to set timeout from CLI for ha supervisor repair (#5627)	❌	Change updates an internal timeout constant without adding a CLI option.
Ability to switch container registry used by the system (#5627)	❌	Functionality for switching the container registry is not implemented.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ec537a and e35863c.

📒 Files selected for processing (1)

• cmd/supervisor_repair.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

`*/**(html|markdown|md)`: - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure t...

*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

• Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
• In step-by-step instructions, front the location phrase in the instructional sentence.
• In step-by-step instructions, front the 'goal' in the instructional sentence.
• In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
• do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

• cmd/supervisor_repair.go

`*/**(html|markdown|md)`: - Use bold to mark UI strings. - If "" are used to mark UI strings, replace them by bold.

*/**(html|markdown|md): - Use bold to mark UI strings.

• If "" are used to mark UI strings, replace them by bold.

• cmd/supervisor_repair.go

`*/**(html|markdown|md)`: - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"

*/**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"

• cmd/supervisor_repair.go

`*/**(html|markdown|md)`: - Use sentence-style capitalization also in headings.

*/**(html|markdown|md): - Use sentence-style capitalization also in headings.

• cmd/supervisor_repair.go

`*/**(html|markdown|md)`: do not comment on HTML used for icons

*/**(html|markdown|md): do not comment on HTML used for icons

• cmd/supervisor_repair.go

`*/**(html|markdown|md)`: Avoid flagging inline HTML for embedding videos in future reviews for this repository.

*/**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.

• cmd/supervisor_repair.go

🔇 Additional comments (1)

cmd/supervisor_repair.go (1)

31-31: Appropriate timeout adjustment.

The change from ContainerOperationTimeout to ContainerDownloadTimeout aligns with the PR objective to increase the timeout for container downloads during supervisor repair operations. This modification will provide more time for downloads to complete, particularly beneficial for users with slower internet connections or when downloading larger containers.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[KostyaSha]

@agners is it possible to choose docker registry? AFAIK ha is available in both registries

[agners]

No, that is currently not possible. Also not all component are pushed to the Docker registry (Supervisor and plug-ins are only pushed to ghcr.io at this point).