Run golangci-lint without fixing in CI#633
Conversation
📝 WalkthroughWalkthroughA single argument ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Running with fixes enabled (which we have in the config) means golangci-lint returns silently with success if it managed to fix all its findings. Disable fixing in CI explicitly to make it error out instead.
d7d2c8b to
75dd7bd
Compare
sairon
left a comment
There was a problem hiding this comment.
Thanks, looks fine after merging your other PRs.
Running with fixes enabled (which we have in the config) means golangci-lint returns silently with success if it managed to fix all its findings. Disable fixing in CI explicitly to make it error out instead.
This will likely make the CI fail, depending on when exactly it is merged. #632 contains the fixes against current master, so if this is applied on top of it, it should succeed (unless other issues have cropped up meanwhile).
Summary by CodeRabbit
Release Notes
No user-facing changes in this release. This update contains internal development and CI/CD configuration improvements only. There are no new features, bug fixes, or other changes that directly impact end-users.