Skip to content

Run golangci-lint without fixing in CI#633

Merged
sairon merged 2 commits intohome-assistant:masterfrom
scop:fix/golangci-fix-false-in-ci
Mar 31, 2026
Merged

Run golangci-lint without fixing in CI#633
sairon merged 2 commits intohome-assistant:masterfrom
scop:fix/golangci-fix-false-in-ci

Conversation

@scop
Copy link
Copy Markdown
Member

@scop scop commented Feb 2, 2026

Running with fixes enabled (which we have in the config) means golangci-lint returns silently with success if it managed to fix all its findings. Disable fixing in CI explicitly to make it error out instead.

This will likely make the CI fail, depending on when exactly it is merged. #632 contains the fixes against current master, so if this is applied on top of it, it should succeed (unless other issues have cropped up meanwhile).

Summary by CodeRabbit

Release Notes

No user-facing changes in this release. This update contains internal development and CI/CD configuration improvements only. There are no new features, bug fixes, or other changes that directly impact end-users.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

A single argument (--fix=false) is added to the golangci-lint GitHub Action step in the CI/CD workflow, explicitly disabling auto-fixing behavior during linting checks.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/golangci-lint.yml
Added args: --fix=false to the golangci-lint action step to disable automatic issue fixing and enforce report-only linting behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: disabling golangci-lint's auto-fix behavior in CI, which is the exact purpose of adding the --fix=false argument.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Running with fixes enabled (which we have in the config) means
golangci-lint returns silently with success if it managed to fix all its
findings. Disable fixing in CI explicitly to make it error out instead.
@scop scop force-pushed the fix/golangci-fix-false-in-ci branch from d7d2c8b to 75dd7bd Compare February 3, 2026 17:09
Copy link
Copy Markdown
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks fine after merging your other PRs.

@sairon sairon merged commit 265ce92 into home-assistant:master Mar 31, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants