Skip to content

Conversation

@Olle-Mineur
Copy link

@Olle-Mineur Olle-Mineur commented May 15, 2025

Breaking change

Proposed change

Add support for charge_state_lifetime_energy_used in the Tessie integration. The sensor was missing, the data already existed in diagnostic information.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Olle-Mineur and others added 2 commits May 15, 2025 09:17
Co-authored-by: wind1s <44732263+wind1s@users.noreply.github.com>
Co-authored-by: wind1s <44732263+wind1s@users.noreply.github.com>
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Olle-Mineur

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 15, 2025 09:58
@home-assistant
Copy link

Hey there @Bre77, mind taking a look at this pull request as it has been labeled with an integration (tessie) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tessie can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tessie Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Bre77
Copy link
Contributor

Bre77 commented May 15, 2025

Make sure you also update https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/tessie.markdown and link the two PRs, but otherwise this looks good to me.

@Olle-Mineur
Copy link
Author

The sensor was added without testing on a real Tesla car. Would be helpful if someone could check the function.
We built the sensor with information from diagnostics posted by @pacemaker82 .

@Bre77
Copy link
Contributor

Bre77 commented May 15, 2025

@home-assistant rename Add Lifetime energy used sensor to Tessie

@home-assistant home-assistant bot changed the title Add charge_state_lifetime_energy_used to tessie sensors Add Lifetime energy used sensor to Tessie May 15, 2025
@Bre77
Copy link
Contributor

Bre77 commented May 15, 2025

The sensor was added without testing on a real Tesla car.

Thats a good point I noticed the test snapshot value was "unknown" which means this value isnt in the fixture. So in addition to a real world test the fixture may also need to be updated (which can be done using data from the diag).

@Olle-Mineur
Copy link
Author

Make sure you also update https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/tessie.markdown and link the two PRs, but otherwise this looks good to me.

I created a PR to the docs repository. Unsure if I chose the correct branch.
Here is the PR: home-assistant/home-assistant.io#39037

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Jul 17, 2025
@github-actions github-actions bot closed this Jul 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing lifetime charge kWh?

3 participants