Add missing data descriptions for airq integration#166318
Draft
Sibgatulin wants to merge 2 commits intohome-assistant:devfrom
Draft
Add missing data descriptions for airq integration#166318Sibgatulin wants to merge 2 commits intohome-assistant:devfrom
Sibgatulin wants to merge 2 commits intohome-assistant:devfrom
Conversation
home-assistant
Bot
added
cla-signed
integration: airq
new-feature
small-pr
|
Hey there @dl2080, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing data_description entries for the airq integration’s config flow and polishes existing option descriptions, improving UI help text shown during setup/options.
Changes:
- Add
data_descriptionfor thepasswordfield in the zeroconf discovery confirmation step. - Add
data_descriptionforip_addressandpasswordin the manual user setup step. - Add missing trailing punctuation to option field descriptions.
joostlek
requested changes
Mar 24, 2026
| }, | ||
| "data_description": { | ||
| "ip_address": "The IP address, (m)DNS name, or hostname of your air-Q device on your local network.", | ||
| "password": "The password of your air-Q device." |
Member
There was a problem hiding this comment.
You can use a reference for this one
Contributor
Author
There was a problem hiding this comment.
I wanted to clarify that I understood you and data_description correctly: do you mean some reference, other than "[%key:common::config_flow::data::password%]"? Since the latter resolves to just Password and I thought that the point of data_description was to add information on top of the label in the UI 🤔
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
epenet
changed the title
data_descriptions for airq integration`ip_address` / `CONF_IP_ADDRESS` has become a misnomer, and `host` / `CONF_HOST` would suit this field much better now. In order not to necessitate a migration, this commit maps `ip_address` to `host` only in the UI. Additionally, make a few phrasing changes following copilot's suggestions.
Sibgatulin
added a commit
to CorantGmbH/home-assistant-core
that referenced
this pull request
Mar 24, 2026
I will instead change it to `done` in home-assistant#166318 Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a few missing descriptions.
Once this is merged, the following open PR can be merged too: #166184
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: