Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Victron GX entity translation behavior for main_topic metrics (so state/option translations keep working) and updates device relationships to use the upstream parent/child device model.
Changes:
- Ensure
translation_key/placeholders are always set on Victron entities, includingmain_topicmetrics, while still letting HA use the device name for the entity name. - Update device registry
via_devicemapping to usedevice.parent_deviceinstead of hardcodingsystem_0. - Adjust/add tests to cover the corrected translation key behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/victron_gx/entity.py |
Always set translation_key/placeholders; keep main_topic entities device-named by forcing _attr_name=None. |
homeassistant/components/victron_gx/hub.py |
Set via_device using the parent_device relationship. |
tests/components/victron_gx/test_sensor.py |
Update regression assertion for main_topic sensor translation key behavior. |
tests/components/victron_gx/test_select.py |
Add regression test ensuring main_topic selects still set translation_key. |
Comment on lines
+140
to
+141
| # name should be None (uses device name via has_entity_name) | ||
| assert entity.name is None |
There was a problem hiding this comment.
Use the entity registry entry’s original_name (or assert state.attributes["friendly_name"]) instead of entity.name to validate that the integration didn’t set an entity name; entity.name here only reflects a user override and won’t catch regressions in the entity’s computed name.
Suggested change
| # name should be None (uses device name via has_entity_name) | |
| assert entity.name is None | |
| # original_name should be None (uses device name via has_entity_name) | |
| assert entity.original_name is None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixing a bug I introduced while fixing CR comments. Main entities still need translation key so in the case of selects or enum sensor they will still have the list of options.
Also, one line change to move to the new relationship between devices instead of hardcoding the SYSTEM_0 device as root.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: