Rename domain variable in tests#172575
Open
epenet wants to merge 1 commit into
Open
Conversation
home-assistant
Bot
added
cla-signed
code-quality
core
has-tests
integration: anthropic
integration: dynalite
integration: http
integration: logbook
integration: openai_conversation
small-pr
Contributor
|
Hey there @ziv1234, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
|
Hey there @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
|
Hey there @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves test readability by renaming local variables used as Home Assistant integration domains when calling async_setup_component.
Changes:
- Renames
component,comp, andplatformlocals/parameters todomainwhere they represent integration domains. - Updates related entity IDs and service calls to use the renamed variable.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/components/anthropic/test_conversation.py |
Renames Assist API setup loop variable to domain. |
tests/components/dynalite/common.py |
Renames service test helper parameter from platform to domain. |
tests/components/http/test_init.py |
Renames setup loop variable to domain. |
tests/components/logbook/test_init.py |
Renames repeated setup loop variables to domain. |
tests/components/logbook/test_websocket_api.py |
Renames repeated setup loop variables to domain. |
tests/components/openai_conversation/test_conversation.py |
Renames Assist API setup loop variable to domain. |
Shulyaka
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Rename
comp/component/platformtodomainin tests, when used withasync_setup_componentType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: